➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author xtreak
Recipients cjw296, julianhille, lisroach, mariocj89, marseel, michael.foord, xtreak
Date 2019-11-26.04:51:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1574743876.02.0.727028087.issue38895@roundup.psfhosted.org>
In-reply-to
Content 
> This is already done in master branch ;)

Thanks, I noticed the speed improvement in master and 3.7 but assumed it's due to some other optimisation in master.

> Do you mind if I create PR for it? I would like to start contributing to CPython ;)

Sure, I will be happy to review. I would like to know others thoughts on this too on deferring whether the attribute is async check to the mock's own creation in _get_child_mock instead of making the parent mock construction slightly expensive as per the current approach. We can at least backport the NonCallableMock.__init__ signature fix which seems safe to make an improvement.

Thanks
History
Date User Action Args
2019-11-26 04:51:16xtreaksetrecipients: + xtreak, cjw296, michael.foord, lisroach, mariocj89, julianhille, marseel
2019-11-26 04:51:16xtreaksetmessageid: <1574743876.02.0.727028087.issue38895@roundup.psfhosted.org>
2019-11-26 04:51:16xtreaklinkissue38895 messages
2019-11-26 04:51:15xtreakcreate