Author vstinner
Recipients vstinner
Date 2019-11-20.11:19:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1574248781.81.0.0994039593531.issue38835@roundup.psfhosted.org>
In-reply-to
Content
Pablo asked on PR 17231:
> Do you want to left the empty macro in Include/pyfpe.h?

https://github.com/python/cpython/pull/17231#pullrequestreview-319366200

I replied:
> If someone wants to remove them, I would suggest to first deprecate them, and wait at least one Python release before removing them. And do that in a separated issue: https://bugs.python.org/issue38835 title is "pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API", it's not directly related :-)

https://github.com/python/cpython/pull/17231#issuecomment-555732122

In short, I'm not interested to remove it right now :-)

The initial issue has been fixed, so I close the issue. Thanks for your review Pablo ;-)
History
Date User Action Args
2019-11-20 11:19:41vstinnersetrecipients: + vstinner
2019-11-20 11:19:41vstinnersetmessageid: <1574248781.81.0.0994039593531.issue38835@roundup.psfhosted.org>
2019-11-20 11:19:41vstinnerlinkissue38835 messages
2019-11-20 11:19:41vstinnercreate