This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author xtreak
Recipients cjw296, lisroach, mariocj89, michael.foord, piscvau, xtreak
Date 2019-11-10.04:49:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1573361366.33.0.271459329886.issue38757@roundup.psfhosted.org>
In-reply-to
Content
Currently, the exception is not instantiated. Maybe we can check if it's callable and pass args, kwargs to the exception constructor to be raised.

diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
index a48132c5b1..f5bcb911f5 100644
--- a/Lib/unittest/mock.py
+++ b/Lib/unittest/mock.py
@@ -1145,7 +1145,10 @@ class CallableMixin(Base):
         effect = self.side_effect
         if effect is not None:
             if _is_exception(effect):
-                raise effect
+                if _callable(effect):
+                    raise effect(*args, **kwargs)
+                else:
+                    raise effect
             elif not _callable(effect):
                 result = next(effect)
                 if _is_exception(result):
History
Date User Action Args
2019-11-10 04:49:26xtreaksetrecipients: + xtreak, cjw296, michael.foord, lisroach, mariocj89, piscvau
2019-11-10 04:49:26xtreaksetmessageid: <1573361366.33.0.271459329886.issue38757@roundup.psfhosted.org>
2019-11-10 04:49:26xtreaklinkissue38757 messages
2019-11-10 04:49:26xtreakcreate