Message356314
Currently, the exception is not instantiated. Maybe we can check if it's callable and pass args, kwargs to the exception constructor to be raised.
diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
index a48132c5b1..f5bcb911f5 100644
--- a/Lib/unittest/mock.py
+++ b/Lib/unittest/mock.py
@@ -1145,7 +1145,10 @@ class CallableMixin(Base):
effect = self.side_effect
if effect is not None:
if _is_exception(effect):
- raise effect
+ if _callable(effect):
+ raise effect(*args, **kwargs)
+ else:
+ raise effect
elif not _callable(effect):
result = next(effect)
if _is_exception(result): |
|
Date |
User |
Action |
Args |
2019-11-10 04:49:26 | xtreak | set | recipients:
+ xtreak, cjw296, michael.foord, lisroach, mariocj89, piscvau |
2019-11-10 04:49:26 | xtreak | set | messageid: <1573361366.33.0.271459329886.issue38757@roundup.psfhosted.org> |
2019-11-10 04:49:26 | xtreak | link | issue38757 messages |
2019-11-10 04:49:26 | xtreak | create | |
|