Author serhiy.storchaka
Recipients serhiy.storchaka
Date 2019-10-30.20:01:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1572465703.12.0.701099038847.issue38650@roundup.psfhosted.org>
In-reply-to
Content
Currently the variable PyStructSequence_UnnamedField has type "char *". It is used as a special value for setting to the name field of PyStructSequence_Field. But the type of the name field is "const char *".

I propose to change the declaration of PyStructSequence_UnnamedField to "const char * const". Makes it referring to immutable character string and make it itself immutable.

It is binary compatible change, but some user code can complain at compilation time if it uses PyStructSequence_UnnamedField in unusual way (assigns to the "char *" variable, etc). It is very unlikely.
History
Date User Action Args
2019-10-30 20:01:43serhiy.storchakasetrecipients: + serhiy.storchaka
2019-10-30 20:01:43serhiy.storchakasetmessageid: <1572465703.12.0.701099038847.issue38650@roundup.psfhosted.org>
2019-10-30 20:01:43serhiy.storchakalinkissue38650 messages
2019-10-30 20:01:42serhiy.storchakacreate