Message 354729 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	eryksun, hroncok, jkloth, pablogsal, paul.moore, petr.viktorin, steve.dower, tim.golden, vstinner, zach.ware
Date	2019-10-15.13:42:59
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1571146979.49.0.682208456752.issue38470@roundup.psfhosted.org>
In-reply-to

Content
> create_long_path isn't taking into account _write_atomic in Lib/importlib/_bootstrap_external.py. Yeah, I found the same issue: https://github.com/python/cpython/pull/16778#issuecomment-541764285 I began to write a complex change to take _write_atomic() in account, but the test became super complex. I don't think that it's worth it. So I wrote a much simpler PR. https://github.com/python/cpython/pull/16789#issuecomment-541918432 Anyway, the issue should now be fixed.

> create_long_path isn't taking into account _write_atomic in Lib/importlib/_bootstrap_external.py.

Yeah, I found the same issue:
https://github.com/python/cpython/pull/16778#issuecomment-541764285

I began to write a complex change to take _write_atomic() in account, but the test became super complex. I don't think that it's worth it. So I wrote a much simpler PR.
https://github.com/python/cpython/pull/16789#issuecomment-541918432

Anyway, the issue should now be fixed.

History
Date	User	Action	Args
2019-10-15 13:42:59	vstinner	set	recipients: + vstinner, paul.moore, tim.golden, jkloth, petr.viktorin, zach.ware, eryksun, steve.dower, hroncok, pablogsal
2019-10-15 13:42:59	vstinner	set	messageid: <1571146979.49.0.682208456752.issue38470@roundup.psfhosted.org>
2019-10-15 13:42:59	vstinner	link	issue38470 messages
2019-10-15 13:42:59	vstinner	create