Author steve.dower
Recipients ZackerySpytz, lukasz.langa, steve.dower
Date 2019-10-08.15:47:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1570549673.69.0.954284840542.issue38410@roundup.psfhosted.org>
In-reply-to
Content
You're right, they need either your patch or PyErr_WriteUnraisable(NULL) before returning.

Łukasz - this needs a fix in 3.8, but we don't have to necessarily change the (internal, but exposed) ABI. For 3.9, we'll fix it properly, but for 3.8 I'll let you make the call whether we can also add a return value to these functions.

-PyAPI_FUNC(void) _PyEval_SetAsyncGenFirstiter(PyObject *);
+PyAPI_FUNC(int) _PyEval_SetAsyncGenFirstiter(PyObject *);
 PyAPI_FUNC(PyObject *) _PyEval_GetAsyncGenFirstiter(void);
-PyAPI_FUNC(void) _PyEval_SetAsyncGenFinalizer(PyObject *);
+PyAPI_FUNC(int) _PyEval_SetAsyncGenFinalizer(PyObject *);
History
Date User Action Args
2019-10-08 15:47:53steve.dowersetrecipients: + steve.dower, lukasz.langa, ZackerySpytz
2019-10-08 15:47:53steve.dowersetmessageid: <1570549673.69.0.954284840542.issue38410@roundup.psfhosted.org>
2019-10-08 15:47:53steve.dowerlinkissue38410 messages
2019-10-08 15:47:53steve.dowercreate