➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients desbma, giampaolo.rodola, gregory.p.smith, izbyshev, patrick.mclean, rhettinger, twouters, vstinner
Date 2019-09-25.13:57:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1569419832.76.0.727908622451.issue36046@roundup.psfhosted.org>
In-reply-to
Content 
> As mentioned in the code review for Victor's fix, it feels like the big conditional on the use of self._posix_spawn in Popen._execute_child should perhaps be pulled into _posix_spawn, or at least refactored so it's closer to _posix_spawn, with some explanation about what is or isn't supported by _posix_spawn and why.     

Maybe, yes. But having tests in the caller avoids to pass the very long list of arguments. Especially, it avoids to pass arguments which are not supposed by posix_spawn() :-)

_execute_child() has 21 arguments... is that really reasonable? Maybe we should put these stuff into a temporary object?
History
Date User Action Args
2019-09-25 13:57:12vstinnersetrecipients: + vstinner, twouters, rhettinger, gregory.p.smith, giampaolo.rodola, desbma, izbyshev, patrick.mclean
2019-09-25 13:57:12vstinnersetmessageid: <1569419832.76.0.727908622451.issue36046@roundup.psfhosted.org>
2019-09-25 13:57:12vstinnerlinkissue36046 messages
2019-09-25 13:57:12vstinnercreate