Message 352693 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	malin
Recipients	Greg Price, aeros, malin, mark.dickinson, rhettinger, sir-sigurd, vstinner
Date	2019-09-18.05:16:22
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1568783782.98.0.8117906267.issue37812@roundup.psfhosted.org>
In-reply-to

Content
> I agree that both changes should be reverted. There is another commit after the two commits: https://github.com/python/cpython/commit/c6734ee7c55add5fdc2c821729ed5f67e237a096 It is troublesome to revert them. PR 16146 is on-going, maybe we can request the author to replace `Py_UNREACHABLE()` with `assert(0)`.

> I agree that both changes should be reverted.

There is another commit after the two commits:
https://github.com/python/cpython/commit/c6734ee7c55add5fdc2c821729ed5f67e237a096

It is troublesome to revert them.

PR 16146 is on-going, maybe we can request the author to replace `Py_UNREACHABLE()` with `assert(0)`.

History
Date	User	Action	Args
2019-09-18 05:16:23	malin	set	recipients: + malin, rhettinger, mark.dickinson, vstinner, Greg Price, sir-sigurd, aeros
2019-09-18 05:16:22	malin	set	messageid: <1568783782.98.0.8117906267.issue37812@roundup.psfhosted.org>
2019-09-18 05:16:22	malin	link	issue37812 messages
2019-09-18 05:16:22	malin	create