This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients barry, eryksun, nanjekyejoannah, pitrou, vstinner
Date 2019-09-12.09:49:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1568281789.69.0.469693213778.issue32847@roundup.psfhosted.org>
In-reply-to
Content
Copy of my comment on the review:
https://github.com/python/cpython/pull/15496#pullrequestreview-287311626

I'm not excited by adding a new builtin symbol: IMHO this module already exists too many symbols.

I'm not convinced that it's worth it. There is exactly 0 line of code in CPython code base which expects ENOTEMPTY errno. So it looks like an artifical use case.

I recall that when PEP 3151 was implemented, the implementation replaced a lot of code using "except OSError as exc: if exc.errno == XXX: ... else: raise" with "except : ..." which was neat.

But again, I don't see any usage of ENOTEMPTY in the Python stdlib.

Are you aware of 3rd party code expecting ENOTEMPTY? How many projects?

Adding a builtin symbol is a significant change, it should be well motived.
History
Date User Action Args
2019-09-12 09:49:49vstinnersetrecipients: + vstinner, barry, pitrou, eryksun, nanjekyejoannah
2019-09-12 09:49:49vstinnersetmessageid: <1568281789.69.0.469693213778.issue32847@roundup.psfhosted.org>
2019-09-12 09:49:49vstinnerlinkissue32847 messages
2019-09-12 09:49:49vstinnercreate