Message 352016 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	sfreilich
Recipients	cjw296, gregory.p.smith, lisroach, mariocj89, michael.foord, sfreilich, xtreak
Date	2019-09-11.19:07:16
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1568228836.89.0.806339542426.issue36871@roundup.psfhosted.org>
In-reply-to

Content
This is still not totally fixed. This solves the underlying error with method specs, but not the bug that was causing the error-swallowing in assert_has_calls: https://github.com/python/cpython/blob/ee536b2020b1f0baad1286dbd4345e13870324af/Lib/unittest/mock.py#L2216 expected = [self._call_matcher(c) for c in calls] cause = expected if isinstance(expected, Exception) else None isinstance(expected, Exception) is never true, because expected is always a list. It should instead be: cause = next((e for e in expected if isinstance(e, Exception)), None)

This is still not totally fixed. This solves the underlying error with method specs, but not the bug that was causing the error-swallowing in assert_has_calls:

https://github.com/python/cpython/blob/ee536b2020b1f0baad1286dbd4345e13870324af/Lib/unittest/mock.py#L2216

expected = [self._call_matcher(c) for c in calls]
cause = expected if isinstance(expected, Exception) else None

isinstance(expected, Exception) is never true, because expected is always a list. It should instead be:

cause = next((e for e in expected if isinstance(e, Exception)), None)

History
Date	User	Action	Args
2019-09-11 19:07:16	sfreilich	set	recipients: + sfreilich, gregory.p.smith, cjw296, michael.foord, lisroach, mariocj89, xtreak
2019-09-11 19:07:16	sfreilich	set	messageid: <1568228836.89.0.806339542426.issue36871@roundup.psfhosted.org>
2019-09-11 19:07:16	sfreilich	link	issue36871 messages
2019-09-11 19:07:16	sfreilich	create