Author ncoghlan
Recipients Jim Fasarakis-Hilliard, ZackerySpytz, docs@python, ncoghlan, serhiy.storchaka
Date 2019-09-03.10:59:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1567508396.71.0.361387962425.issue30076@roundup.psfhosted.org>
In-reply-to
Content
Reviewing this again now, I think my previous naming suggestion is problematic, as it encourages conflating two different concepts that use similar syntax:

* collecting arbitrary positional parameters in a tuple (VAR_POSITIONAL) or arbitrary keyword parameters in a dictionary (VAR_POSITIONAL, VAR_KEYWORD)
* unpacking function arguments from iterables (BUILD_VAR_POSITIONAL) or mappings (BUILD_VAR_KEYWORD)

I think the fix for that error is straightforward though: replace "VAR" with "ARG" in the new opcode names, giving:

* BUILD_ARG_POSITIONAL
* BUILD_ARG_KEYWORD

That should also read nicely with Zackery's documentation updates.
History
Date User Action Args
2019-09-03 10:59:56ncoghlansetrecipients: + ncoghlan, docs@python, serhiy.storchaka, Jim Fasarakis-Hilliard, ZackerySpytz
2019-09-03 10:59:56ncoghlansetmessageid: <1567508396.71.0.361387962425.issue30076@roundup.psfhosted.org>
2019-09-03 10:59:56ncoghlanlinkissue30076 messages
2019-09-03 10:59:56ncoghlancreate