Message350352
Thanks, Raymond, for the review on GH-15216!
Shortly after posting this issue, I noticed a very similar story in CHECK_BINOP. I've just posted GH-15448 to similarly make returns explicit there. It basically consists of a number of repetitions of
- CHECK_BINOP(self, other);
+ if (!PyLong_Check(self) || !PyLong_Check(other)) {
+ Py_RETURN_NOTIMPLEMENTED;
+ }
with the names `self` and `other` varying from site to site. Though the expanded version isn't literally a `return` statement, I think it functions almost as well as one for the purposes that explicitness serves here, and much better so than a reference to `CHECK_BINOP`. |
|
Date |
User |
Action |
Args |
2019-08-24 06:05:00 | Greg Price | set | recipients:
+ Greg Price, rhettinger, mark.dickinson, malin, sir-sigurd, aeros |
2019-08-24 06:05:00 | Greg Price | set | messageid: <1566626700.73.0.76039930717.issue37812@roundup.psfhosted.org> |
2019-08-24 06:05:00 | Greg Price | link | issue37812 messages |
2019-08-24 06:05:00 | Greg Price | create | |
|