Author Greg Price
Recipients Greg Price, aeros, malin, mark.dickinson, rhettinger, sir-sigurd
Date 2019-08-24.06:05:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Thanks, Raymond, for the review on GH-15216!

Shortly after posting this issue, I noticed a very similar story in CHECK_BINOP.  I've just posted GH-15448 to similarly make returns explicit there.  It basically consists of a number of repetitions of

-    CHECK_BINOP(self, other);
+    if (!PyLong_Check(self) || !PyLong_Check(other)) {
+    }

with the names `self` and `other` varying from site to site.  Though the expanded version isn't literally a `return` statement, I think it functions almost as well as one for the purposes that explicitness serves here, and much better so than a reference to `CHECK_BINOP`.
Date User Action Args
2019-08-24 06:05:00Greg Pricesetrecipients: + Greg Price, rhettinger, mark.dickinson, malin, sir-sigurd, aeros
2019-08-24 06:05:00Greg Pricesetmessageid: <>
2019-08-24 06:05:00Greg Pricelinkissue37812 messages
2019-08-24 06:05:00Greg Pricecreate