Author steve.dower
Recipients Jeffrey.Kintscher, ZackerySpytz, daveb, eryksun, josh.r, lukasz.langa, ned.deily, paul.moore, steve.dower, tim.golden, vstinner, xflr6, zach.ware
Date 2019-08-22.15:13:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1566486794.94.0.926554189764.issue37549@roundup.psfhosted.org>
In-reply-to
Content
Thanks Zackery for the patch!

> The problem is just console pseudohandles in Windows 7 and earlier.

Should we add a version check as well [1]? I'm not totally comfortable with bitmasking a handle here, but if we only do this additional check on Win7 then I'm okay with it.

And if we add the check, I'd rather this be a function than a macro. It's getting too complicated to read :)

[1]: https://docs.microsoft.com/en-us/windows/win32/api/versionhelpers/nf-versionhelpers-iswindows8orgreater
History
Date User Action Args
2019-08-22 15:13:14steve.dowersetrecipients: + steve.dower, paul.moore, vstinner, tim.golden, ned.deily, lukasz.langa, zach.ware, eryksun, josh.r, xflr6, ZackerySpytz, Jeffrey.Kintscher, daveb
2019-08-22 15:13:14steve.dowersetmessageid: <1566486794.94.0.926554189764.issue37549@roundup.psfhosted.org>
2019-08-22 15:13:14steve.dowerlinkissue37549 messages
2019-08-22 15:13:14steve.dowercreate