Message 349863 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vinay0410
Recipients	Dmitrii Ivaniushin, asvetlov, vinay0410, yselivanov
Date	2019-08-16.14:03:06
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1565964186.36.0.236329148717.issue37703@roundup.psfhosted.org>
In-reply-to

Content
Hi Andrew, Thanks for replying! I understand that the behavior change is not backward compatible. But the current behavior is a bit ambiguous ad mentioned by Dimitri, therefore I have updated the documentation and opened a Pull request. I would be very glad if you could review it. Thanks! Also, would adding an optional argument like force_cancel=False to ``gather.cancel``, which won't return even if gather is done be backward compatible. Should I open a PR with this change also, so that you can better review it and see if it looks good.

Hi Andrew,
Thanks for replying!

I understand that the behavior change is not backward compatible. But the current behavior is a bit ambiguous ad mentioned by Dimitri, therefore I have updated the documentation and opened a Pull request.

I would be very glad if you could review it.
Thanks!

Also, would adding an optional argument like force_cancel=False to ``gather.cancel``, which won't return even if gather is done be backward compatible. Should I open a PR with this change also, so that you can better review it and see if it looks good.

History
Date	User	Action	Args
2019-08-16 14:03:06	vinay0410	set	recipients: + vinay0410, asvetlov, yselivanov, Dmitrii Ivaniushin
2019-08-16 14:03:06	vinay0410	set	messageid: <1565964186.36.0.236329148717.issue37703@roundup.psfhosted.org>
2019-08-16 14:03:06	vinay0410	link	issue37703 messages
2019-08-16 14:03:06	vinay0410	create