Author vstinner
Recipients Greg Price, benjamin.peterson, ezio.melotti, miss-islington, vstinner
Date 2019-08-13.12:35:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1565699715.58.0.283787314068.issue37760@roundup.psfhosted.org>
In-reply-to
Content
"from typing import *"

I like to run pyflakes time to time on the Python code base. Please avoid "import *" since it prevents pyflakes (and other code analyzers) to find bugs. Example:

$ pyflakes Tools/unicode/makeunicodedata.py
Tools/unicode/makeunicodedata.py:35: 'from typing import *' used; unable to detect undefined names
Tools/unicode/makeunicodedata.py:921: 'Iterator' may be undefined, or defined from star imports: typing
Tools/unicode/makeunicodedata.py:921: 'List' may be undefined, or defined from star imports: typing
Tools/unicode/makeunicodedata.py:921: 'Iterator' may be undefined, or defined from star imports: typing
...
History
Date User Action Args
2019-08-13 12:35:15vstinnersetrecipients: + vstinner, benjamin.peterson, ezio.melotti, Greg Price, miss-islington
2019-08-13 12:35:15vstinnersetmessageid: <1565699715.58.0.283787314068.issue37760@roundup.psfhosted.org>
2019-08-13 12:35:15vstinnerlinkissue37760 messages
2019-08-13 12:35:15vstinnercreate