Message349118
> Can I submit my PR now?
Sure, though if others want to weigh in on wording they should feel free to do it here.
> I forgot to ask about tests? I see there is test_crypt.py under Lib\test. Do you have any thoughts on how to test this?
It should continue to "successfully" skip tests when _crypt isn't built. So as long as you raise ImportError, this should be fine. |
|
Date |
User |
Action |
Args |
2019-08-06 17:23:25 | steve.dower | set | recipients:
+ steve.dower, terry.reedy, paul.moore, jafo, tim.golden, zach.ware, shireenrao |
2019-08-06 17:23:25 | steve.dower | set | messageid: <1565112205.98.0.995624795325.issue25172@roundup.psfhosted.org> |
2019-08-06 17:23:25 | steve.dower | link | issue25172 messages |
2019-08-06 17:23:25 | steve.dower | create | |
|