Author ElizabethU
Recipients ElizabethU, cjw296, mariocj89, michael.foord, p-ganssle, serhiy.storchaka, xtreak
Date 2019-07-22.05:33:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1563773588.04.0.137314386797.issue37555@roundup.psfhosted.org>
In-reply-to
Content
Serhiy, thanks for pointing that out. I generally agree with everything in that thread, and learned some new things (I had no idea count(), index() and remove() used needle on the left side!) However, I'm not trying to spearhead a rewrite of everything. I think what I'm advocating for on the two assertEqual order tests is that as Guido mentioned "people should fix their __eq__ implementation to properly return NotImplemented". _Call's __eq__ currently has no path to NotImplemented, and if it did, those tests would pass. Perhaps I should change it from the or statement to make it more clear that's what's effectively happening.

I'd like to talk more about what a good solution would be for the _Call __eq__ 
issue, since people (including myself!) have concerns, but I think it would be best to open another bug for that, and not scope creep myself. I've reverted all the commits having to do with that part so hopefully the issue with _call_matcher can get sorted separately, and then we can talk about this as it's own issue.
History
Date User Action Args
2019-07-22 05:33:08ElizabethUsetrecipients: + ElizabethU, cjw296, michael.foord, serhiy.storchaka, p-ganssle, mariocj89, xtreak
2019-07-22 05:33:08ElizabethUsetmessageid: <1563773588.04.0.137314386797.issue37555@roundup.psfhosted.org>
2019-07-22 05:33:08ElizabethUlinkissue37555 messages
2019-07-22 05:33:07ElizabethUcreate