Author jdemeyer
Recipients jdemeyer, lukasz.langa, nascheme, ncoghlan, pablogsal, petr.viktorin, scoder, serhiy.storchaka, vstinner
Date 2019-06-12.09:38:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1560332287.93.0.67701681276.issue37221@roundup.psfhosted.org>
In-reply-to
Content
Technically, tp_print was replaced by tp_vectorcall_offset.

But that doesn't answer the question how we should deal with tp_print backwards compatibility. Cython does

FooType.tp_print = 0;

With this in mind, simply replacing tp_print by tp_vectorcall_offset is unsafe as it would break types that actually use vectorcall (there aren't many for now, but who knows how this will change in the future).

It would be safer to replace tp_print by tp_vectorcall since setting that to 0 won't break anything (neither for now, nor when PR 13930 is merged).
History
Date User Action Args
2019-06-12 09:38:07jdemeyersetrecipients: + jdemeyer, nascheme, ncoghlan, scoder, vstinner, petr.viktorin, lukasz.langa, serhiy.storchaka, pablogsal
2019-06-12 09:38:07jdemeyersetmessageid: <1560332287.93.0.67701681276.issue37221@roundup.psfhosted.org>
2019-06-12 09:38:07jdemeyerlinkissue37221 messages
2019-06-12 09:38:07jdemeyercreate