Author serhiy.storchaka
Recipients Arfrever, alex, barry, docs@python, eric.snow, ethan.furman, mjacob, ncoghlan, python-dev, rhettinger, serhiy.storchaka, vstinner
Date 2019-06-05.07:39:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1559720385.55.0.532067464244.issue17576@roundup.psfhosted.org>
In-reply-to
Content
Mark, I think you can reopen the PR and merge it in 3.9 now.

As for my proposition to use the FutureWarning first, I think it is not necessary. The behavior change is very subtle and will affects only int subclasses with overridden __index__. Similar changes (preferring __index__ over __int__) have been made in 3.8 without preceding FutureWarning. And similar minor changes were made in the past.

On other hand, I am not sure that __index__ should be used for int subclasses. We already have the int content, so we can create an exact int with _PyLong_Copy().
History
Date User Action Args
2019-06-05 07:39:45serhiy.storchakasetrecipients: + serhiy.storchaka, barry, rhettinger, ncoghlan, vstinner, Arfrever, alex, docs@python, ethan.furman, python-dev, eric.snow, mjacob
2019-06-05 07:39:45serhiy.storchakasetmessageid: <1559720385.55.0.532067464244.issue17576@roundup.psfhosted.org>
2019-06-05 07:39:45serhiy.storchakalinkissue17576 messages
2019-06-05 07:39:45serhiy.storchakacreate