This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author dwvisser
Recipients dwvisser, vinay.sajip, zach.ware
Date 2019-05-31.13:26:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1559309176.17.0.717808680311.issue37101@roundup.psfhosted.org>
In-reply-to
Content
It is with great surprise and sadness that I report that I found that performance measurements don't support merging this change. I'm attaching my performance test script. I ran it with/without the logging filters for 1000000 iterations, e.g., ./python all 1000000

The results on my system were as follows, where the numbers may be interpreted as milliseconds per 1000 log messages:		
		
          No Filters    3 Filters
master    17.9          19.8
CBO-37101 19.6          23.1

I imagine I could put a guard 'if' statement that would restore the 'no filters' performance to match 'master', but my use of generators apparently causes the use of significantly more cycles than the existing code.
History
Date User Action Args
2019-05-31 13:26:16dwvissersetrecipients: + dwvisser, vinay.sajip, zach.ware
2019-05-31 13:26:16dwvissersetmessageid: <1559309176.17.0.717808680311.issue37101@roundup.psfhosted.org>
2019-05-31 13:26:16dwvisserlinkissue37101 messages
2019-05-31 13:26:16dwvissercreate