Message 342494 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	mbussonn
Recipients	Anthony Sottile, mbussonn, serhiy.storchaka
Date	2019-05-14.18:12:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1557857548.05.0.988764949852.issue36917@roundup.psfhosted.org>
In-reply-to

Content
Would it be useful to add a default implementation of `visit_Constant(self, node)` on NodeVisitor that go through all the isinstance() check and call the appropriate backward compatible method ? We would still have the simplification without having any breakage in backward compatibility. That feels like best of both worlds ?

Would it be useful to add a default implementation of `visit_Constant(self, node)` on NodeVisitor that go through all the isinstance() check and call the appropriate backward compatible method ? 

We would still have the simplification without having any breakage in backward compatibility. 

That feels like best of both worlds ?

History
Date	User	Action	Args
2019-05-14 18:12:28	mbussonn	set	recipients: + mbussonn, serhiy.storchaka, Anthony Sottile
2019-05-14 18:12:28	mbussonn	set	messageid: <1557857548.05.0.988764949852.issue36917@roundup.psfhosted.org>
2019-05-14 18:12:28	mbussonn	link	issue36917 messages
2019-05-14 18:12:27	mbussonn	create