Message 341649 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	dfortunov
Recipients	Mariatta, cheryl.sabella, dfortunov, mblahay, rhettinger, trey, xtreak
Date	2019-05-06.21:23:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1557177822.42.0.773866091799.issue36582@roundup.psfhosted.org>
In-reply-to

Content
PR submitted here: https://github.com/python/cpython/pull/13138 Rather than adding three different tests for the different code paths I chose to collapse the three different code paths by surfacing the underlying str.encode() defaults in the method signature of UserString.encode(), taking it down to a one-line implementation. @xtreak: Thanks for the super-helpful triage and failing test case!

PR submitted here:
https://github.com/python/cpython/pull/13138

Rather than adding three different tests for the different code paths I chose to collapse the three different code paths by surfacing the underlying str.encode() defaults in the method signature of UserString.encode(), taking it down to a one-line implementation.

@xtreak: Thanks for the super-helpful triage and failing test case!

History
Date	User	Action	Args
2019-05-06 21:23:42	dfortunov	set	recipients: + dfortunov, rhettinger, Mariatta, trey, cheryl.sabella, xtreak, mblahay
2019-05-06 21:23:42	dfortunov	set	messageid: <1557177822.42.0.773866091799.issue36582@roundup.psfhosted.org>
2019-05-06 21:23:42	dfortunov	link	issue36582 messages
2019-05-06 21:23:42	dfortunov	create