Author serhiy.storchaka
Recipients alex, christian.heimes, dstufft, janssen, serhiy.storchaka
Date 2019-04-10.07:22:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Currently some exceptions can be swallowed in the _ssl module. The proposed PR fixes this. Some examples:

* Use PyDict_GetItemWithError() instead of PyDict_GetItem(). The latter swallows any exceptions. Although it is very unlikely that an exception be raised here, it may be possible.

* Do not overwrite arbitrary exceptions in PyUnicode_FSConverter(), PyUnicode_AsASCIIString() and PyObject_GetBuffer(). MemoryError most likely can be raised in the first two cases. Only expected exceptions (TypeError or UnicodeEncodeError) will now be replaced with a TypeError, and cadata type will be checked before trying to get a buffer or encode.
Date User Action Args
2019-04-10 07:22:39serhiy.storchakasetrecipients: + serhiy.storchaka, janssen, christian.heimes, alex, dstufft
2019-04-10 07:22:39serhiy.storchakasetmessageid: <>
2019-04-10 07:22:39serhiy.storchakalinkissue36583 messages
2019-04-10 07:22:39serhiy.storchakacreate