Author lemburg
Recipients ezio.melotti, inada.naoki, lemburg, scoder, serhiy.storchaka, vstinner
Date 2019-03-18.21:06:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1552943200.08.0.443974941236.issue36346@roundup.psfhosted.org>
In-reply-to
Content
I'd change the title of this bpo item to "Prepare for removing the whcar_t caching in the Unicode C API".

Note that the wchar_t caching was put in place to allow for external applications and C code to easily and efficiently interface with Python. By removing it you will slow down such code significantly, esp. on Linux and Windows where wchar_t code is fairly common (one of the reasons we added UCS4 in Python was to make the interaction with Linux wchar_t code more efficient).

This should be clearly mentioned as part of the change and the compile time flags.


BTW: You have a few other changes in the PR which don't have anything to do with the intended removal:

-    envsize = PySequence_Fast_GET_SIZE(keys);
-    if (PySequence_Fast_GET_SIZE(values) != envsize) {
+    envsize = PyList_GET_SIZE(keys);
+    if (PyList_GET_SIZE(values) != envsize) {
History
Date User Action Args
2019-03-18 21:06:40lemburgsetrecipients: + lemburg, scoder, vstinner, ezio.melotti, inada.naoki, serhiy.storchaka
2019-03-18 21:06:40lemburgsetmessageid: <1552943200.08.0.443974941236.issue36346@roundup.psfhosted.org>
2019-03-18 21:06:40lemburglinkissue36346 messages
2019-03-18 21:06:39lemburgcreate