Author rougeth
Recipients rougeth
Date 2019-03-16.20:25:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1552767909.74.0.734583361576.issue36322@roundup.psfhosted.org>
In-reply-to
Content
Reading the documentation for `dbm.gnu.open` I noticed that there were a typo in the `flags` argument, it was documented as `flag`, in plural form.

The same typo was present for `dbm.ndbm.open`, but in this case, `flag` makes more sense than `flags`, since the function accepts only one option as a flag.

I opened a PR [1] fixing both typos, but I’d like to discuss if makes sense to rename the argument on `dbm.ndbm.open` from `flags` to `flag`. As point out by  @remilapeyre, this change would be backwards compatible, since we cannot use the function with keyword arguments.

>>> dbm.ndbm.open(filename=‘foo’, flags=‘r’, mode=438)
Traceback (most recent call last):
  File “<stdin>”, line 1, in <module>
TypeError: open() takes no keyword arguments

What do you folks think about it?

1 - https://github.com/python/cpython/pull/12095
History
Date User Action Args
2019-03-16 20:25:09rougethsetrecipients: + rougeth
2019-03-16 20:25:09rougethsetmessageid: <1552767909.74.0.734583361576.issue36322@roundup.psfhosted.org>
2019-03-16 20:25:09rougethlinkissue36322 messages
2019-03-16 20:25:09rougethcreate