Author steve.dower
Recipients Anthony Sottile, paul.moore, steve.dower, tim.golden, zach.ware
Date 2019-03-12.15:17:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1552403875.71.0.141836001334.issue36264@roundup.psfhosted.org>
In-reply-to
Content
I like the patch, but I'm not sure all the tests are properly preserving the real value of USERPROFILE.

Modifying this value could have a real impact on the rest of the process, so we should be very careful to undo it regardless of test result. (Modifying HOME is not a as big a deal since, as you point out, it's not "real" ;) )

Also, it's probably better to get the current value and check against that, rather than setting it to a known value. One day we might do the right thing and switch expanduser() from the environment variables to the correct API, which would break the test.
History
Date User Action Args
2019-03-12 15:17:55steve.dowersetrecipients: + steve.dower, paul.moore, tim.golden, zach.ware, Anthony Sottile
2019-03-12 15:17:55steve.dowersetmessageid: <1552403875.71.0.141836001334.issue36264@roundup.psfhosted.org>
2019-03-12 15:17:55steve.dowerlinkissue36264 messages
2019-03-12 15:17:55steve.dowercreate