Author giampaolo.rodola
Recipients brett.cannon, davin, eric.snow, giampaolo.rodola, lukasz.langa, nascheme, osvenskan, pitrou, pmpp, rhettinger, ronaldoussoren, skrah, terry.reedy, yselivanov
Date 2019-02-11.22:52:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1549925524.76.0.974274845205.issue35813@roundup.psfhosted.org>
In-reply-to
Content
I submitted an initial review / comments in the PR. I think this is good for a first iteration in order to understand what APIs to expose publicly (also, keep in mind I may not have a full picture of how this is intended to be used precisely).

As for the doc, I find it a bit too verbose. If the namespace change is accepted consider doing the following:

* document `SharedMemoryManager` right after `SyncManager`. That would let you reuse the description for `Semaphore`, `Barrier`, `Lock`, etc.
* within `SharedMemoryManager` doc link/point to a different section of the doc where you explain the whole thing in more details, and also document the remaining APIs 

Just an idea. Writing good doc is not easy and it requires actually putting hands on it. 

Hope this helps.
History
Date User Action Args
2019-02-11 22:52:04giampaolo.rodolasetrecipients: + giampaolo.rodola, brett.cannon, nascheme, rhettinger, terry.reedy, ronaldoussoren, pitrou, osvenskan, skrah, pmpp, lukasz.langa, eric.snow, yselivanov, davin
2019-02-11 22:52:04giampaolo.rodolasetmessageid: <1549925524.76.0.974274845205.issue35813@roundup.psfhosted.org>
2019-02-11 22:52:04giampaolo.rodolalinkissue35813 messages
2019-02-11 22:52:04giampaolo.rodolacreate