Message 333105 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	elfring
Recipients	elfring
Date	2019-01-06.12:13:12
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1546776792.69.0.991179182294.issue35671@roundup.psfhosted.org>
In-reply-to

Content
I would like to point out that identifiers like “__DYNAMIC_ANNOTATIONS_H__” and “_Py_memory_order” do not fit to the expected naming convention of the C++ language standard. https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier Would you like to adjust your selection for unique names? * https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Include/dynamic_annotations.h#L56 * https://github.com/python/cpython/blob/130893debfd97c70e3a89d9ba49892f53e6b9d79/Include/internal/pycore_atomic.h#L36

I would like to point out that identifiers like “__DYNAMIC_ANNOTATIONS_H__” and “_Py_memory_order” do not fit to the expected naming convention of the C++ language standard.
https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier

Would you like to adjust your selection for unique names?
* https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Include/dynamic_annotations.h#L56
* https://github.com/python/cpython/blob/130893debfd97c70e3a89d9ba49892f53e6b9d79/Include/internal/pycore_atomic.h#L36

History
Date	User	Action	Args
2019-01-06 12:13:16	elfring	set	recipients: + elfring
2019-01-06 12:13:12	elfring	set	messageid: <1546776792.69.0.991179182294.issue35671@roundup.psfhosted.org>
2019-01-06 12:13:12	elfring	link	issue35671 messages
2019-01-06 12:13:12	elfring	create