Author remi.lapeyre
Recipients ammar2, iceboy, remi.lapeyre
Date 2019-01-02.13:05:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1546434344.78.0.10371616106.issue35634@roundup.psfhosted.org>
In-reply-to
Content
I prepared a patch to make the check when there is only one dict, it may be the less surprising change.

BTW, I got lost when looking for the root cause  of this change because grepping for the error message did not work as it has line breaks:

-                            PyErr_Format(PyExc_TypeError,
-                                    "%.200s%.200s got multiple "
-                                    "values for keyword argument '%U'",
-                                    PyEval_GetFuncName(func),
-                                    PyEval_GetFuncDesc(func),
-                                    key);

Can we add a note like https://www.kernel.org/doc/html/v4.12/process/coding-style.html#breaking-long-lines-and-strings to the PEP7?

> However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them.

It would help in such situations.
History
Date User Action Args
2019-01-02 13:05:46remi.lapeyresetrecipients: + remi.lapeyre, iceboy, ammar2
2019-01-02 13:05:44remi.lapeyresetmessageid: <1546434344.78.0.10371616106.issue35634@roundup.psfhosted.org>
2019-01-02 13:05:44remi.lapeyrelinkissue35634 messages
2019-01-02 13:05:44remi.lapeyrecreate