Author ncoghlan
Recipients brett.cannon, eric.snow, hyu, miss-islington, ncoghlan, ned.deily, paul.moore, serhiy.storchaka, steve.dower, tim.golden, vstinner, zach.ware
Date 2018-12-28.15:02:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1546009361.89.0.583780863183.issue35596@roundup.psfhosted.org>
In-reply-to
Content
Reviewing the diff at https://github.com/python/cpython/compare/v3.7.1...v3.7.2 the only item I've spotted that seems like it could even plausibly be related is the tweak at https://github.com/python/cpython/compare/v3.7.1...v3.7.2#diff-baf5eab51059d96fb8837152dab0d1a4

(Click the Files tab to get your browser to jump to the anchor in the second link)

That's a change to the function that emits the "Fatal Python error: initfsencoding: unable to load the file system codec" message.

That change means that embedding applications could potentially be hitting the codec name resolution at https://github.com/python/cpython/blob/3.7/Python/pylifecycle.c#L1643 with the filesystem encoding set as "ascii", rather than handling that case through the "get_locale_encoding()" branch, which does the initial codec name lookup with the filesystem encoding still set to NULL (and hence falling back to the locale encoding as the default).

However, the only way that new branch could trigger is if check_force_ascii() (at https://github.com/python/cpython/blob/v3.7.2/Python/fileutils.c#L100 ) is returning 1 for some reason, which we only expect it to do on some misbehaving BSD OSes, not on Windows: https://github.com/python/cpython/pull/10233
History
Date User Action Args
2018-12-28 15:02:42ncoghlansetrecipients: + ncoghlan, brett.cannon, paul.moore, vstinner, tim.golden, ned.deily, eric.snow, zach.ware, serhiy.storchaka, steve.dower, miss-islington, hyu
2018-12-28 15:02:41ncoghlansetmessageid: <1546009361.89.0.583780863183.issue35596@roundup.psfhosted.org>
2018-12-28 15:02:41ncoghlanlinkissue35596 messages
2018-12-28 15:02:41ncoghlancreate