Author xtreak
Recipients Alexander Oblovatniy, azsorkin, cjw296, dojutsu-user, mariocj89, michael.foord, nekobon, r.david.murray, rbcollins, rhettinger, xtreak
Date 2018-12-27.05:39:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1545889196.99.0.931089294611.issue24928@roundup.psfhosted.org>
In-reply-to
Content
Hi Vaibhav,

As noted in the thread the issue is fixed in 3.6 and above due to dict order being guaranteed. But it would be nice to have the test in the patch converted as a unit test. With respect to backport the fixes are backported to https://github.com/testing-cabal/mock to make mock library available for older versions of Python which would required the fix since dict order is not guaranteed in older versions. Once the test to CPython is merged you can make a PR to the mock repo with the fix and the test.

I haven't started working on a PR for this so feel free to go ahead.
History
Date User Action Args
2018-12-27 05:39:57xtreaksetrecipients: + xtreak, rhettinger, rbcollins, cjw296, r.david.murray, michael.foord, nekobon, azsorkin, Alexander Oblovatniy, mariocj89, dojutsu-user
2018-12-27 05:39:56xtreaksetmessageid: <1545889196.99.0.931089294611.issue24928@roundup.psfhosted.org>
2018-12-27 05:39:56xtreaklinkissue24928 messages
2018-12-27 05:39:56xtreakcreate