Author xtreak
Recipients Alexander Oblovatniy, azsorkin, cjw296, mariocj89, michael.foord, nekobon, r.david.murray, rbcollins, rhettinger, xtreak
Date 2018-12-21.07:39:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1545377978.61.0.788709270274.issue24928@psf.upfronthosting.co.za>
In-reply-to
Content
Thinking about it further the attached test is based on the ordering of dict and hence works only on 3.6 and above. But this test will be backported to mock on PyPI where this will fail on 2.7 and 3.4, 3.5. Is it okay to apply the fix that makes backporting easy though it has no effect on current CPython implementation or to only apply the test since it's fixed in CPython due to dict implementation detail and make sure the cabal backporting is done with this detail taken into account to run test only on 3.6+. But the latter makes the issue still prevalent in cabal's mock repo.

I think it's better to apply the fix along with the test that will make it easy on both ends. I am not aware of the backport process for mock on PyPI so feedback will be helpful on this.
History
Date User Action Args
2018-12-21 07:39:38xtreaksetrecipients: + xtreak, rhettinger, rbcollins, cjw296, r.david.murray, michael.foord, nekobon, azsorkin, Alexander Oblovatniy, mariocj89
2018-12-21 07:39:38xtreaksetmessageid: <1545377978.61.0.788709270274.issue24928@psf.upfronthosting.co.za>
2018-12-21 07:39:38xtreaklinkissue24928 messages
2018-12-21 07:39:38xtreakcreate