Author vstinner
Recipients gregory.p.smith, izbyshev, nanjekyejoannah, pablogsal, pitrou, serhiy.storchaka, vstinner
Date 2018-12-20.16:42:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1545324159.74.0.788709270274.issue35537@psf.upfronthosting.co.za>
In-reply-to
Content
Serhiy Storchaka, Alexey Izbyshev: I read and understood your valid concerns.

restore_signals=True will be quickly implemented, and so posix_spawn() code path will be tested by more tests of test_subprocess. If not, I will ensure that missing tests will be added.

Enhance _posixsubprocess to use vfork() is an interesting project, but IMHO it's complementary and doesn't replace all advantages of posix_spawn().

I am going to merge the PR tomorrow, except if someone sees a good reason to not merge it. I prefer to merge the PR early in the 3.8 development cycle to have more time to handle any issue if someone notice bugs. If something goes badly, we will be able to easily revert the change. Don't worry, I like to revert changes ;-)

Again, I'm mentoring Joannah who is learning Python, so I prefer to move step by step (with small steps :-)). We will support more and more subprocess.Popen options.
History
Date User Action Args
2018-12-20 16:42:39vstinnersetrecipients: + vstinner, gregory.p.smith, pitrou, serhiy.storchaka, izbyshev, pablogsal, nanjekyejoannah
2018-12-20 16:42:39vstinnersetmessageid: <1545324159.74.0.788709270274.issue35537@psf.upfronthosting.co.za>
2018-12-20 16:42:39vstinnerlinkissue35537 messages
2018-12-20 16:42:38vstinnercreate