Author michael.brandl@aid-driving.eu
Recipients michael.brandl@aid-driving.eu
Date 2018-12-13.15:22:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1544714559.52.0.788709270274.issue35483@psf.upfronthosting.co.za>
In-reply-to
Content
In Ubuntu 16.04, with python 3.5, as well as custom built 3.6 and 3.7.1:

Given a file foo.txt (with content "foo") and a symlink myLink to it, packed in a tar,  and   a file bar.txt (with content "bar") with a symlink myLink to it, packed in another tar,
unpacking the two tars into the same folder (first foo.tar, then bar.tar) leads to the following behavior:

In GNU tar, the directory will contain:
foo.txt (content "foo")
bar.txt (content "bar")
myLink ->bar.txt.

Using python's tarfile however, the result of calling tarfile.extractall on the two tars will give:
foo.txt (content "bar")
bar.txt (content "bar")
myLink ->foo.txt.


Repro: 
1. Unpack the attached symLinkBugRepro.tar.gz into a new folder
2. run > bash repoSymlink.bash (does exactly what is described above)
3. if the last two lines of the output are "bar" and "bar" (instead of "foo" and "bar"), then the content of foo.txt has been overwritten.

Note that this is related to issues like
https://bugs.python.org/issue23228
https://bugs.python.org/issue1167128
https://bugs.python.org/issue19974
https://bugs.python.org/issue10761

None of these issues target the issue at hand, however.

The problem lies in line 2201 of https://github.com/python/cpython/blob/master/Lib/tarfile.py:
The assumption is that any exception only comes from the os not supporting symlinks. But here, the exception comes from the symlink already existing, which should be caught separately. The correct behavior is then NOT to extract the member, but rather to overwrite the symlink (as GNU tar does).
History
Date User Action Args
2018-12-13 15:22:39michael.brandl@aid-driving.eusetrecipients: + michael.brandl@aid-driving.eu
2018-12-13 15:22:39michael.brandl@aid-driving.eusetmessageid: <1544714559.52.0.788709270274.issue35483@psf.upfronthosting.co.za>
2018-12-13 15:22:39michael.brandl@aid-driving.eulinkissue35483 messages
2018-12-13 15:22:39michael.brandl@aid-driving.eucreate