Author mbussonn
Recipients mbussonn, minrk, njs, willingc, yselivanov
Date 2018-12-10.17:11:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1544461899.73.0.788709270274.issue34616@psf.upfronthosting.co.za>
In-reply-to
Content
So through time our heuristic to check wether a code should be async or not grew: 

https://github.com/ipython/ipython/blob/320d21bf56804541b27deb488871e488eb96929f/IPython/core/async_helpers.py#L94-L165

There also seem to be some code that uses `codeop.compile_command` to figure out wether the user code is valid syntax (or not), so that would need some update too. 

I'm thinking of submitting a talk at PyCon to explain what we've discover so far in IPython.
History
Date User Action Args
2018-12-10 17:11:39mbussonnsetrecipients: + mbussonn, njs, yselivanov, willingc, minrk
2018-12-10 17:11:39mbussonnsetmessageid: <1544461899.73.0.788709270274.issue34616@psf.upfronthosting.co.za>
2018-12-10 17:11:39mbussonnlinkissue34616 messages
2018-12-10 17:11:39mbussonncreate