Author vstinner
Recipients ned.deily, paul.moore, steve.dower, terry.reedy, tim.golden, vinay.sajip, vstinner, xtreak, zach.ware
Date 2018-12-07.14:50:13
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1544194213.97.0.788709270274.issue34977@psf.upfronthosting.co.za>
In-reply-to
Content
> We haven't done RC yet - why is pushing this now so bad?

I reverted your change because it broke all Windows buildbots, and we have a policy to revert a change if buildbots turn red and no fix can be found in 2 hours:
https://pythondev.readthedocs.io/ci.html#revert-on-fail


> Most of the change is purely additive and does not modify the code base, the rest is Windows-only or tests.

nitpicking: Your change modify venv and two tests, it's not purely Windows-only :-) By the way, as I wrote in my email, I would prefer to see the venv+tests change pushed in separated change (and explain why you do these changes).


> I'll add checks for outdated build machines, but there has to be a release of this or it remains untestable, so it'll either be from my branch or from the release branch.

Sorry, I don't know Windows App Store, I don't understand the restriction "there has to be a release of this or it remains untestable". Would you mind to elaborate?

Do you mean that buildbots must upgrade to VS 2017? Can Python 3.6 and 3.7 be compiled without any issue on VS 2017? Maybe send an email to buildbot-status if you want to see more buildbots running VS 2017 rather than VS 2015.

--

There was a small bug in your PR, in PC/launcher.c, fixed by commit 4c49da0cb7434c676d70b9ccf38aca82ac0d64a9 (bpo-35436):

+        if (executable == NULL) {
+            error(RC_NO_MEMORY, L"A memory allocation failed");
+        }
History
Date User Action Args
2018-12-07 14:50:14vstinnersetrecipients: + vstinner, terry.reedy, paul.moore, vinay.sajip, tim.golden, ned.deily, zach.ware, steve.dower, xtreak
2018-12-07 14:50:13vstinnersetmessageid: <1544194213.97.0.788709270274.issue34977@psf.upfronthosting.co.za>
2018-12-07 14:50:13vstinnerlinkissue34977 messages
2018-12-07 14:50:13vstinnercreate