Author jmadden
Recipients jmadden
Date 2018-11-21.15:12:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1542813152.98.0.788709270274.issue35291@psf.upfronthosting.co.za>
In-reply-to
Content
Using Python 2.7.15, if a BufferedWriter wraps an IO object that duplicates the memoryview passed to the IO object's `write` method, that memoryview leaks. 

This script demonstrates the problem by leaking a memoryview for each iteration of the loop (if the `flush` is skipped, the leaks are less frequent but still occur):

```
from __future__ import print_function

import io
import gc

def count_memoryview():
    result = 0
    for x in gc.get_objects():
        if type(x) is memoryview:
            result += 1
    return result

class FileLike(object):
    closed = False

    def writable(self):
        return True

    def write(self, data):
        memoryview(data) # XXX: This causes the problem
        return len(data)


bf = io.BufferedWriter(FileLike())

i = 0
memoryview_count = 0

while True:
    if i == 0 or i % 100 == 0:
        # This reports 100 new memoryview objects each time
        old = memoryview_count
        new = count_memoryview()
        print(i, "memoryview", new, "+%s" % (new - old))
        memoryview_count = new

    bf.write(b"test")
    bf.flush()
    i += 1
```

The leak can also be observed using the operating system's memory monitoring tools for the process (seen on both Fedora and macOS).

Commenting out the line in `FileLike.write` that makes a duplicate memoryview of the given buffer solves the leak. 

Deleting the BufferedWriter doesn't appear to reclaim the leaked memoryviews.

I can't duplicate this in Python 3.4 or above.

Originally reported to gevent in https://github.com/gevent/gevent/issues/1318

Possibly related to Issue 26720 and Issue 15994
History
Date User Action Args
2018-11-21 15:12:33jmaddensetrecipients: + jmadden
2018-11-21 15:12:32jmaddensetmessageid: <1542813152.98.0.788709270274.issue35291@psf.upfronthosting.co.za>
2018-11-21 15:12:32jmaddenlinkissue35291 messages
2018-11-21 15:12:32jmaddencreate