Author ammar2
Recipients ammar2, eric.smith, larry, rhettinger, serhiy.storchaka
Date 2018-10-01.18:26:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1538418380.29.0.545547206417.issue34838@psf.upfronthosting.co.za>
In-reply-to
Content
I've attached a PR that implements this. From the looks of it, there aren't a lot of uses of subclass_of within argument clinic converted functions at the moment. Additionally, most of the places it is used tend to have some non object arguments so a call to _PyArg_ParseStack() gets placed anyway.

Attached as part of separate commit in the PR is the conversion of some files over to use the new code. These are mostly just to serve as examples. 

While converting would still leave a call to ParseStack in most places, I'd like to do some benchmarking and figure out if there is still a benefit. Like you said, the fact that branch-prediction is easier might be useful given that these functions are usually called with the right types of arguments anyway.
History
Date User Action Args
2018-10-01 18:26:20ammar2setrecipients: + ammar2, rhettinger, larry, eric.smith, serhiy.storchaka
2018-10-01 18:26:20ammar2setmessageid: <1538418380.29.0.545547206417.issue34838@psf.upfronthosting.co.za>
2018-10-01 18:26:20ammar2linkissue34838 messages
2018-10-01 18:26:20ammar2create