Author ned.deily
Recipients anthony-flury, bbayles, berker.peksag, eric.araujo, ezio.melotti, michael.foord, ned.deily, rbcollins
Date 2018-09-13.23:47:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1536882472.29.0.956365154283.issue32933@psf.upfronthosting.co.za>
In-reply-to
Content
While I think arguments could be made either way, this seems to me to be somewhat more of a bugfix (rather than a feature) in the sense that mock_open did not correctly emulate a real textfile open at least for an idiom that is commonly used (while acknowledging that mock_open does not claim to fully implement open or all classes of IO objects).  The key question to me is would backporting this change likely cause any change in behavior to existing programs running on 3.7.x or 3.6.x.  If yes, then we definitely shouldn't backport it.  If not, then there is now the issue that people using mock_open on 3.7.x (or possibly 3.6.x) still can't depend on its behavior unless they explicitly check for, say, 3.7.1 or 3.6.7.  That's not particularly user friendly, either.  So perhaps it *is* best to not backport; if the functionality is needed in earlier releases, one could create a PyPI package to provide it, for example.
History
Date User Action Args
2018-09-13 23:47:52ned.deilysetrecipients: + ned.deily, rbcollins, ezio.melotti, eric.araujo, michael.foord, berker.peksag, anthony-flury, bbayles
2018-09-13 23:47:52ned.deilysetmessageid: <1536882472.29.0.956365154283.issue32933@psf.upfronthosting.co.za>
2018-09-13 23:47:52ned.deilylinkissue32933 messages
2018-09-13 23:47:52ned.deilycreate