Message324903
For what its worth, I'm +1 with Serhiy that we raise an exception
on a non-string argument, including the case where the caller forgets to
provide a reason at all.
I don't think that @skip with no reason was ever intended to work (it
certainly wasn't documented as working) and as this only effects tests,
not production code, I don't think we ought to be constrained by "bug
compatibility" concerns. Fixing broken tests is easier than fixing
broken production code. |
|
Date |
User |
Action |
Args |
2018-09-10 00:36:51 | steven.daprano | set | recipients:
+ steven.daprano, rbcollins, ezio.melotti, michael.foord, zach.ware, serhiy.storchaka, Naitree Zhu |
2018-09-10 00:36:51 | steven.daprano | link | issue34596 messages |
2018-09-10 00:36:50 | steven.daprano | create | |
|