➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Naitree Zhu
Recipients Naitree Zhu, steven.daprano, zach.ware
Date 2018-09-06.15:48:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1536248907.64.0.56676864532.issue34596@psf.upfronthosting.co.za>
In-reply-to
Content 
Hi @zach.ware, Just to make sure I'm getting this right (first time contributing to cpython...)

Now I need to open 4 PRs at GitHub,

- 1 PR to master branch, with following changes: raise TypeError when `reason` is not a string. (Include unit test.)
- 3 PRs to 3.7, 3.6, and 2.7, with following changes: Setting `reason` to "Unconditionally" when `reason` is a function. (Include unit test.)

Looking good?
History
Date User Action Args
2018-09-06 15:48:27Naitree Zhusetrecipients: + Naitree Zhu, steven.daprano, zach.ware
2018-09-06 15:48:27Naitree Zhusetmessageid: <1536248907.64.0.56676864532.issue34596@psf.upfronthosting.co.za>
2018-09-06 15:48:27Naitree Zhulinkissue34596 messages
2018-09-06 15:48:27Naitree Zhucreate