This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author p-ganssle
Recipients belopolsky, izbyshev, p-ganssle, pitrou, serhiy.storchaka, taleinat, vstinner
Date 2018-08-29.16:04:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1535558640.77.0.56676864532.issue34481@psf.upfronthosting.co.za>
In-reply-to
Content
I'm finding it very difficult to reconcile these things. I'm not entirely sure, but we may need to take a performance hit in normal strftime if we want to make this work with surrogate characters, which really does not appeal to me (though we can certainly improve to some degree).

One major question here: Is anyone (@vstinner, @belopolsky?) know why time's strftime opportunistically uses wcsftime instead of strftime? It makes the code *way* more complicated and difficult to read / maintain - are there platforms that provide wcstrftime and not strftime?

Also, related, it seems according to https://bugs.python.org/issue10653#msg243660 that there may have been a regression in issue #10653, which may be related here.

Either way, some note should probably be made in the code to clarify exactly *why* these choices were made in the code, in case the situation has changed.
History
Date User Action Args
2018-08-29 16:04:00p-gansslesetrecipients: + p-ganssle, belopolsky, pitrou, vstinner, taleinat, serhiy.storchaka, izbyshev
2018-08-29 16:04:00p-gansslesetmessageid: <1535558640.77.0.56676864532.issue34481@psf.upfronthosting.co.za>
2018-08-29 16:04:00p-gansslelinkissue34481 messages
2018-08-29 16:04:00p-gansslecreate