Author Michael.Felt
Recipients Michael.Felt, christian.heimes
Date 2018-08-21.07:47:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <15fa7bc4-2c86-686f-263a-9267f0b20fb1@felt.demon.nl>
In-reply-to <1533393423.72.0.56676864532.issue34194@psf.upfronthosting.co.za>
Content
On 04/08/2018 16:37, Michael Felt wrote:
> Some help would really be appreciated!

Gotten a bit further :)

While it does not affect the 'failures', this change decreases 'errors'
by 8 (skipped +1).

I do not expect this to be 'acceptable' - however, I hope this helps an
expert come with some advice.

I played around with defining either OPENSSL_NO_SSL2 or
OPENSSL_VERSION_1_1. However, I do not think the latter is correct (AIX
still goes it - externally, openssl.1.0.2.XXXX, not openssl.1.1.Y.XXXX)
and I felt
the configure process was attempting to use a dynamic process to
establish OPENSSL_NO_SSL2
rather than a definition being added to CFLAGS.

Again - help appreciated!

Before:
FAILED (failures=13, errors=11, skipped=10)
test test_ssl failed

After:
FAILED (failures=13, errors=2, skipped=11)
test test_ssl failed

diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index 2bce4816d2..5fa442cedf 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -5790,9 +5790,11 @@ PyInit__ssl(void)

     /* protocol versions */
 #ifndef OPENSSL_NO_SSL2
+#ifndef _AIX
     PyModule_AddIntConstant(m, "PROTOCOL_SSLv2",
                             PY_SSL_VERSION_SSL2);
 #endif
+#endif
 #ifndef OPENSSL_NO_SSL3
     PyModule_AddIntConstant(m, "PROTOCOL_SSLv3",
                             PY_SSL_VERSION_SSL3);
History
Date User Action Args
2018-08-21 07:47:02Michael.Feltsetrecipients: + christian.heimes
2018-08-21 07:47:02Michael.Feltlinkissue34194 messages
2018-08-21 07:47:02Michael.Feltcreate