Message323375
The following is a fragment of a real code:
~~~
def test_run_xinlude(self):
# stub_stdin(self, Global.get_resource_bytes("tests/core/data/xml/xinclude.xml"))
for next_script_mode in ['doc1', 'doc2']:
for order in ['breadth', 'depth']:
with capture_stdin_and_stdout():
command_line.main(['-r',
order,
'chain',
Global.get_filename("tests/core/data/xml/xinclude.xml"),
'-u',
'http://portonvictor.org/ns/trans/precedence-include',
'-s',
next_script_mode])
self.assertEqual(sys.stdout.buffer.getvalue(), TestUtility.XInclude_output,
"for next_script=%s, order=%s" % (next_script_mode, order))
~~~
I wrote it in one test method instead of four similar methods.
It has the deficiency that if the first test fails, the three remaining tests are skipped.
I propose to add `subtest` context manager to use it like:
~~~
with subtest():
with capture_stdin_and_stdout():
command_line.main(['-r',
order,
'chain',
Global.get_filename("tests/core/data/xml/xinclude.xml"),
'-u',
'http://portonvictor.org/ns/trans/precedence-include',
'-s',
next_script_mode])
self.assertEqual(sys.stdout.buffer.getvalue(), TestUtility.XInclude_output,
"for next_script=%s, order=%s" % (next_script_mode, order))
~~~
which would split our test into four independent tests. |
|
Date |
User |
Action |
Args |
2018-08-10 17:56:26 | porton | set | recipients:
+ porton |
2018-08-10 17:56:26 | porton | set | messageid: <1533923786.85.0.56676864532.issue34375@psf.upfronthosting.co.za> |
2018-08-10 17:56:26 | porton | link | issue34375 messages |
2018-08-10 17:56:26 | porton | create | |
|