This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients Conrad Ho, CuriousLearner, berker.peksag, demian.brecht, erynofwales, msosey, r.david.murray, sloonz, xgdomingo
Date 2018-08-02.14:28:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1533220106.95.0.56676864532.issue24255@psf.upfronthosting.co.za>
In-reply-to
Content
Conrad: thanks for the effort, but using f-strings with logging is counterproductive.  The idea behind logging is that the logged strings are not materialized unless something actually wants to output them.  Using fstrings means you are doing all the work of formatting the string regardless of whether or not the string is actually going to get written anywhere.  The original patch also retains the debug guards that minimize overhead when debugging is not turned on, which it doesn't look like your patch does.

Regardless, what we need at this stage is a github PR, not a patch :)
History
Date User Action Args
2018-08-02 14:28:27r.david.murraysetrecipients: + r.david.murray, berker.peksag, demian.brecht, erynofwales, CuriousLearner, xgdomingo, sloonz, msosey, Conrad Ho
2018-08-02 14:28:26r.david.murraysetmessageid: <1533220106.95.0.56676864532.issue24255@psf.upfronthosting.co.za>
2018-08-02 14:28:26r.david.murraylinkissue24255 messages
2018-08-02 14:28:26r.david.murraycreate