Author xtreak
Recipients rhettinger, terry.reedy, xtreak
Date 2018-07-23.05:54:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1532325256.19.0.56676864532.issue34193@psf.upfronthosting.co.za>
In-reply-to
Content
This ticket is to address comments by @terry.reedy on GitHub for PR https://github.com/python/cpython/pull/8395.

Ref : https://github.com/python/cpython/pull/8395#issuecomment-406894241

Tests: In the 3 tests before this, the suffix 0, 2, or 3 is the number of arguments given. This would suggest 0a, 0b, 2a, and 3a for the suffixes here. I like 1min, 2min, 1max, and 2max even better. You can wait a bit for other reviews before changing.

Blurb:

Let us be more specific. For the patch as is,
Fix pluralization of 'argument' in TypeError message with 'expected at least/most 1 argument', instead of '1 arguments'.

But if we add all the remaining fixes needed in this file (see below), we could write.
Fix pluralization in TypeError messages in getargs.c: '1 argument' instead of '1 arguments' and '1 element' instead of '1 elements'.

Fixes: This patch follows existing expressions formatted into argument%s:
line 380: (nargs < min ? min : max) == 1 ? "" : "s",
lines 1667 and 2093: (len == 1) ? "" : "s", (parens not needed)

Scope: I think we should finish the job in the file. The next line in both else clauses,
"unpacked tuple should have %s%zd elements,"
should get the same treatment. This may break existing tests. (These are the only two formatted 'elements'.

Fixes for the following will break some test, which will then need fixing also.
542: "expected %d arguments, not %" PY_FORMAT_SIZE_T "d",
1720, "%.200s%s takes %s %d positional arguments"
1799, "%.200s%s takes %s %d positional arguments"
2106, "%200s%s takes %s %d positional arguments (%d given)",
2154: "%.200s%s takes %s %d positional arguments"

I checked all PyErr_Format entries and did not see anything other than %d arguments and %d elements.
History
Date User Action Args
2018-07-23 05:54:16xtreaksetrecipients: + xtreak, rhettinger, terry.reedy
2018-07-23 05:54:16xtreaksetmessageid: <1532325256.19.0.56676864532.issue34193@psf.upfronthosting.co.za>
2018-07-23 05:54:16xtreaklinkissue34193 messages
2018-07-23 05:54:14xtreakcreate