Author giampaolo.rodola
Recipients benhoyt, benjamin.peterson, brett.cannon, giampaolo.rodola, ncoghlan, serhiy.storchaka, stutzbach, tarek, vstinner, yselivanov
Date 2018-06-23.10:53:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1529751200.96.0.56676864532.issue33695@psf.upfronthosting.co.za>
In-reply-to
Content
PR at: https://github.com/python/cpython/pull/7874.
I re-ran benchmarks since shutil code changed after #33695. Linux went from +13.5% to 8.8% and Windows went from +17% to 20.7%.
In the PR I explicitly avoided using a context manager around os.scandir() for now so that patch it's easier to review (will add it before pushing).

Linux (+8.8%)
=============

without patch:
    $ ./python  bench-copytree.py 
    Priming the system's cache...
    7956 files and dirs, repeat 1/3... min = 0.604s
    7956 files and dirs, repeat 2/3... min = 0.603s
    7956 files and dirs, repeat 3/3... min = 0.601s

with patch:
    $ ./python  bench-copytree.py 
    Priming the system's cache...
    7956 files and dirs, repeat 1/3... min = 0.557s
    7956 files and dirs, repeat 2/3... min = 0.548s
    7956 files and dirs, repeat 3/3... min = 0.548s
    best result = 0.548s

Windows (+20.7%)
================

without patch:
    C:\Users\user\Desktop>cpython\PCbuild\win32\python.exe cpython\bench-copytree.py
    Priming the system's cache...
    7956 files and dirs, repeat 1/3... min = 8.275s
    7956 files and dirs, repeat 2/3... min = 8.018s
    7956 files and dirs, repeat 3/3... min = 7.978s
    best result = 7.978s

With patch: 
    C:\Users\user\Desktop>cpython\PCbuild\win32\python.exe cpython\bench-copytree.py
    Priming the system's cache...
    7956 files and dirs, repeat 1/3... min = 6.609s
    7956 files and dirs, repeat 2/3... min = 6.609s
    7956 files and dirs, repeat 3/3... min = 6.609s
    best result = 6.609s
History
Date User Action Args
2018-06-23 10:53:21giampaolo.rodolasetrecipients: + giampaolo.rodola, brett.cannon, ncoghlan, vstinner, benjamin.peterson, tarek, stutzbach, benhoyt, serhiy.storchaka, yselivanov
2018-06-23 10:53:20giampaolo.rodolasetmessageid: <1529751200.96.0.56676864532.issue33695@psf.upfronthosting.co.za>
2018-06-23 10:53:20giampaolo.rodolalinkissue33695 messages
2018-06-23 10:53:20giampaolo.rodolacreate