Author Deniz Bozyigit
Recipients Deniz Bozyigit, eryksun, paul.moore, r.david.murray, steve.dower, tim.golden, zach.ware
Date 2018-06-22.05:30:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1529645449.7.0.56676864532.issue33935@psf.upfronthosting.co.za>
In-reply-to
Content
Hi, thank you for looking into this. I'm aware that the shown patch is not the ideal solution and a mere fix to get my jupyter operational. 

An indication on a workable solution could be the _samefile function in shutil that wraps os.path.samefile:

def _samefile(src, dst):
    # Macintosh, Unix.
    if hasattr(os.path, 'samefile'):
        try:
            return os.path.samefile(src, dst)
        except OSError:
            return False

    # All other platforms: check for same pathname.
    return (os.path.normcase(os.path.abspath(src)) ==
            os.path.normcase(os.path.abspath(dst)))


I understand that the implicit platform differentiation that is done here (see the comment line) is not valid anymore since os.path.samefile is now available on windows systems. It seems that for a windows system the here implemented file name comparison could be workable (even moving it into os.path.samefile?), if the platform is identified correctly.
History
Date User Action Args
2018-06-22 05:30:49Deniz Bozyigitsetrecipients: + Deniz Bozyigit, paul.moore, tim.golden, r.david.murray, zach.ware, eryksun, steve.dower
2018-06-22 05:30:49Deniz Bozyigitsetmessageid: <1529645449.7.0.56676864532.issue33935@psf.upfronthosting.co.za>
2018-06-22 05:30:49Deniz Bozyigitlinkissue33935 messages
2018-06-22 05:30:49Deniz Bozyigitcreate