Author serhiy.storchaka
Recipients ned.deily, ronaldoussoren, serhiy.storchaka
Date 2018-06-15.18:14:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1529086477.01.0.579493977442.issue33871@psf.upfronthosting.co.za>
In-reply-to
Content
The iov_setup() helper in posixmodule.c returns the total size of all buffers. But there is possible an integer overflow because the sequence of buffers can contain the same buffer repeated multiple times.

On 32-bit platform:

>>> import os
>>> f = open('/tmp/temp', 'wb')
>>> os.writev(f.fileno(), [b'x' * 2**16] * 2**15)
-1

Since the overflowed sum is negative, os_writev_impl() returns -1 as a signal of error, but since the exception is not set, -1 is returned as the result of os.writev(). If the overflowed sum is not negative, the sequence of buffers is passed to OS and an OSError is raised:

>>> os.writev(f.fileno(), [b'x' * 2**16] * 2**16)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: [Errno 22] Invalid argument

I have not tested (because have not installed corresponding 32-bit OSes, and it is harder to reproduce on 64-bit), but seems this can even cause a crash in os.sendfile() on FreeBSD, DragonFly BSD and Mac OS.

This sum is used only in os.sendfile() on Mac OS. In all other cases it is enough to return just an error flag. I can't find the documentation for os.sendfile() on Mac OS for checking if this value actually is needed.
History
Date User Action Args
2018-06-15 18:14:37serhiy.storchakasetrecipients: + serhiy.storchaka, ronaldoussoren, ned.deily
2018-06-15 18:14:37serhiy.storchakasetmessageid: <1529086477.01.0.579493977442.issue33871@psf.upfronthosting.co.za>
2018-06-15 18:14:36serhiy.storchakalinkissue33871 messages
2018-06-15 18:14:36serhiy.storchakacreate