Author vstinner
Recipients Christian.Tismer, eric.snow, larry, ned.deily, pitrou, serhiy.storchaka, vstinner
Date 2018-06-10.11:29:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1528630199.98.0.592728768989.issue33738@psf.upfronthosting.co.za>
In-reply-to
Content
It seems like the change broke compilation on Windows, but I'm not sure:

http://buildbot.python.org/all/#/builders/12/builds/959

       (Link target) -> 
         python3.def : error LNK2001: unresolved external symbol PyExceptionClass_Name [D:\buildarea\3.x.ware-win81-release\build\PCbuild\python3dll.vcxproj]
         python3.def : error LNK2001: unresolved external symbol PyIndex_Check [D:\buildarea\3.x.ware-win81-release\build\PCbuild\python3dll.vcxproj]
         python3.def : error LNK2001: unresolved external symbol PyIter_Check [D:\buildarea\3.x.ware-win81-release\build\PCbuild\python3dll.vcxproj]
         D:\buildarea\3.x.ware-win81-release\build\PCbuild\amd64\python3.lib : fatal error LNK1120: 3 unresolved externals [D:\buildarea\3.x.ware-win81-release\build\PCbuild\python3dll.vcxproj]

On the buildbot-status, Ned Deily wrote:

Build failure caused by known failure to rebuild files during compile phase. Worked around by clearing out stale files.  (I *think* there is still an open issue on this.)

Ned: you are thinking at bpo-33614, commit e97ba4c690613d734843db218aeedce2f0e5937f?
History
Date User Action Args
2018-06-10 11:30:00vstinnersetrecipients: + vstinner, pitrou, larry, ned.deily, eric.snow, serhiy.storchaka, Christian.Tismer
2018-06-10 11:29:59vstinnersetmessageid: <1528630199.98.0.592728768989.issue33738@psf.upfronthosting.co.za>
2018-06-10 11:29:59vstinnerlinkissue33738 messages
2018-06-10 11:29:59vstinnercreate